This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Added possibility to set lore or name for snitch items #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍👍 |
|
Addresses CivMC/Civ#222 @Aleksey-Terzi did you close this? Github mobile doesn't show anyone closing it that it closed |
Author
|
Yes, it was me, I forgot about this PR and re-created my fork so PR was closed automatically. |
Protonull
reviewed
May 29, 2023
| this.fieldGenerator = fieldGenerator; | ||
| this.appenders = appenders; | ||
|
|
||
| if (this.item.name != null && this.item.name.length() == 0) |
Protonull
reviewed
May 29, 2023
| if (this.item.name != null && this.item.name.length() == 0) | ||
| this.item.name = null; | ||
|
|
||
| if (this.item.lore != null && this.item.lore.isEmpty()) |
There was a problem hiding this comment.
CollectionUtils.isEmpty(this.item.lore)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item description format in config has been changed.
An example of the lored snitch was added in the default config.